Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] dispose more JS proxies #89559

Merged
merged 10 commits into from
Jul 28, 2023
Merged

[browser] dispose more JS proxies #89559

merged 10 commits into from
Jul 28, 2023

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jul 27, 2023 •
edited
Loading

  • explicitly dispose HTTP AbortController
  • dispose JSException proxy as soon as it was evaluated
  • fix dispose() for JS proxy of a delegate
  • dispose onClose delegate in WS
  • disable FailedRequests_ConnectionClosedWhileReceivingHeaders_Recorded test because of timeouts
  • make mono_assert to print stack trace
  • reorder UninstallWebWorkerInterop so that JS could still call the proxies disposal.

@pavelsavara pavelsavara added this to the 8.0.0 milestone Jul 27, 2023
@pavelsavara pavelsavara requested a review from maraf July 27, 2023 12:03
@pavelsavara pavelsavara self-assigned this Jul 27, 2023
@ghost
Copy link

ghost commented Jul 27, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • explicitly dispose HTTP AbortController
  • dispose JSException proxy as soon as it was evaluated
  • fix dispose() for JS proxy of a delegate
  • dispose onClose delegate in WS
  • disable FailedRequests_ConnectionClosedWhileReceivingHeaders_Recorded test because of timeouts
  • make mono_assert to print stack trace

Attempt MT smoke test of #88084 on CI again

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 27, 2023
Closed
Closed
Closed
Closed
Open
Open
@build-analysis build-analysis bot mentioned this pull request Jul 27, 2023
Open
5 tasks
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara marked this pull request as ready for review July 28, 2023 14:01
@pavelsavara pavelsavara removed the request for review from kg July 28, 2023 14:02
@pavelsavara pavelsavara added the os-browser Browser variant of arch-wasm label Jul 28, 2023
@pavelsavara pavelsavara merged commit 7e12dc7 into dotnet:main Jul 28, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 28, 2023
@pavelsavara pavelsavara deleted the browser_dispose_proxies branch September 2, 2024 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kg kg kg approved these changes

@maraf maraf Awaiting requested review from maraf

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@lambdageek lambdageek Awaiting requested review from lambdageek

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @kg