Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop skipping tests in installer pipeline on linux_x64 #89953

Merged
merged 3 commits into from
Aug 18, 2023

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Aug 3, 2023

  • Explicitly enable tests in installer pipeline on linux_x64.
    • I think these ended up disabled after some infrastructure refactoring where we actually set the crossBuild parameter (before that, it was never set). Since these tests aren't on Helix yet, they are skipped for cross build - unfortunately, this means we have no tests running on linux. For linux_x64, they still work in this configuration, so this change enables tests in that configuration so that we have some linux coverage.
  • Fix uploading of symbols/binaries for investigation on test failure
    • This relied on the skipTests parameter, which stopped being set after some infrastructure refactoring.

installer linux_x64 leg from this PR build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=363131&view=logs&jobId=128f4634-3e62-52f1-6764-cb4c2b8330d4&j=c5f2201a-1517-53df-cad8-ae304147cc38&t=a15e3034-cc18-5a91-b9dd-0aaebf757d0c

@ghost
Copy link

ghost commented Aug 3, 2023

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: elinor-fung
Assignees: -
Labels:

area-Host

Milestone: -

Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test changes look good to me. I can't really comment on the YML changes, don't know enough about that.

Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@elinor-fung elinor-fung merged commit 5b448cf into dotnet:main Aug 18, 2023
83 of 85 checks passed
@elinor-fung elinor-fung deleted the installerPipelineTests branch August 18, 2023 22:03
@ghost ghost locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants