-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop skipping tests in installer pipeline on linux_x64 #89953
Conversation
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue Detailsnull
|
02f7bae
to
d27fc38
Compare
de05973
to
4fced16
Compare
4fced16
to
5649154
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test changes look good to me. I can't really comment on the YML changes, don't know enough about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
crossBuild
parameter (before that, it was never set). Since these tests aren't on Helix yet, they are skipped for cross build - unfortunately, this means we have no tests running on linux. For linux_x64, they still work in this configuration, so this change enables tests in that configuration so that we have some linux coverage.skipTests
parameter, which stopped being set after some infrastructure refactoring.installer linux_x64 leg from this PR build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=363131&view=logs&jobId=128f4634-3e62-52f1-6764-cb4c2b8330d4&j=c5f2201a-1517-53df-cad8-ae304147cc38&t=a15e3034-cc18-5a91-b9dd-0aaebf757d0c