Add units to http.client.active_requests & http.client.open_connections #90020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsAddressimg #89809 (review). @lmolkova please confirm this is correct. @dotnet/ncl or @noahfalk please merge this after the confirmation.
|
MihaZupan
approved these changes
Aug 4, 2023
|
@lmolkova does this match what you were expecting based on your conventions writeup? |
lmolkova
approved these changes
Aug 7, 2023
yes, thank you! |
noahfalk
approved these changes
Aug 7, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #89809 (review). @lmolkova please confirm this is correct. @dotnet/ncl or @noahfalk please merge this after the confirmation.