Fix analyzer warning that is breaking the build #90136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
dotnet-issue-labeler
bot
added
the
needs-area-label
adamsitnik
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
LGTM, thank you for fixing the build @eiriktsarpalis
BTW it would be great to understand why the build got broken (I imagine that enabling new analyzers should require a new PR that should simply fail and require a fix before being merged)
Edit: #89869 most likely run the CI checks before the new analyzer got enabled
|
Tagging subscribers to this area: @directhex Issue DetailsCurrently failing with error:
|
ViktorHofer
approved these changes
Aug 8, 2023
|
Fast merge to unblock CI. |
Jokes aside I am very supportive of that! |
|
I also want that badge now 🤣 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently failing with error: