JIT: Fix emitSplit to properly handle the remainder #90246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emitSplit did not handle the edge case where the last instruction group of the function/funclet resulted in the size to overflow the max. Use a lambda so we can call the necessary code both as part of the loop and after the loop. Fix dotnet#85063
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsemitSplit did not handle the edge case where the last instruction group of the function/funclet resulted in the size to overflow the max. Use a lambda so we can call the necessary code both as part of the loop and after the loop. Fix #85063
|
|
Diff of related JitDump in the Antigen example in #85063 (back on 2032a59, as it does not repro on main): @@ -175,6 +175,9 @@ reserveUnwindInfo(isFunclet=true, isColdCode=false, unwindSize=0x10)
reserveUnwindInfo(isFunclet=true, isColdCode=false, unwindSize=0x10)
Split unwind info into 2 fragments (function/funclet size: 2096588, maximum fragment size: 1048576)
emitSplit: split at IG16039 is size ffdc4, less than requested maximum size of 100000
+emitSplit: split at IG20065 is size ffff0, less than requested maximum size of 100000
reserveUnwindInfo(isFunclet=true, isColdCode=false, unwindSize=0xc)
reserveUnwindInfo: fragment #2:
+reserveUnwindInfo(isFunclet=true, isColdCode=false, unwindSize=0x10)
+reserveUnwindInfo: fragment #3:
reserveUnwindInfo(isFunclet=true, isColdCode=false, unwindSize=0x14) |
|
cc @dotnet/jit-contrib PTAL @BruceForstall |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emitSplit did not handle the edge case where the last instruction group of the function/funclet resulted in the size to overflow the max. Use a lambda so we can call the necessary code both as part of the loop and after the loop.
Fix #85063