Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark AddBinaryFormattedResource obsolete #90346

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Mark AddBinaryFormattedResource obsolete #90346

merged 1 commit into from
Aug 11, 2023

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Aug 10, 2023

Fixes #88217

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned ericstj Aug 10, 2023
@ericstj ericstj requested a review from steveharter August 10, 2023 21:53
@ghost
Copy link

ghost commented Aug 10, 2023

Tagging subscribers to this area: @dotnet/area-system-resources
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #88217

Author: ericstj
Assignees: -
Labels:

area-System.Resources, new-api-needs-documentation
Milestone: -

@ericstj ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Aug 10, 2023
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Aug 10, 2023
@ghost
Copy link

ghost commented Aug 10, 2023 •
edited by ericstj
Loading

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

@ericstj ericstj requested review from rainersigwald, gewarren and a team August 10, 2023 21:54
buyaa-n
buyaa-n approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ericstj ericstj merged commit 624c48d into dotnet:main Aug 11, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2023
@ericstj ericstj added this to the 8.0.0 milestone Oct 16, 2023
@ericstj
Copy link
Member Author

ericstj commented Oct 16, 2023

This was documented in dotnet/docs@9977b6b thank you @gewarren

@ericstj ericstj removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@buyaa-n buyaa-n buyaa-n approved these changes

@gewarren gewarren gewarren approved these changes

@tarekgh tarekgh tarekgh approved these changes

@steveharter steveharter Awaiting requested review from steveharter

@rainersigwald rainersigwald Awaiting requested review from rainersigwald

Assignees

@ericstj ericstj

Labels
area-System.Resources breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. new-api-needs-documentation
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Make AddBinaryFormattedResource obsolete
4 participants
@ericstj @tarekgh @gewarren @buyaa-n