Make Analyzer crashes a warning

[ericstj]

Fixes #78412

@stephentoub - you mentioned:

warnings fail the build and there's nothing a developer can do to address them short of disabling the rule (if any are non-deterministic). We can try it once we're clean, though, and see how it goes.

If new warnings are introduced we can add a NoWarn to the project and file an issue. Agreed that non-deterministic warnings will require undoing this. Hopefully we can track such a thing against an issue and undo it with fixed.

To get clean I suppressed this warning and filled the following issues:
#90356
#90357

[ghost]

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #78412

@stephentoub - you mentioned:

warnings fail the build and there's nothing a developer can do to address them short of disabling the rule (if any are non-deterministic). We can try it once we're clean, though, and see how it goes.

If new warnings are introduced we can add a NoWarn to the project and file an issue. Agreed that non-deterministic warnings will require undoing this. Hopefully we can track such a thing against an issue and undo it with fixed.

To get clean I suppressed this warning and filled the following issues:
#90356
#90357

Author:	ericstj
Assignees:	-
Labels:	area-Meta
Milestone:	-

[stephentoub]

To get clean I suppressed this warning and filled the following issues:

I don't see any suppressions. Did you maybe miss a commit?

[ericstj]

To get clean I suppressed this warning and filled the following issues:

I don't see any suppressions. Did you maybe miss a commit?

Right you are 🤦‍♂️I waited to build clean and filed all the issues but forgot to commit the suppressions.

[stephentoub]

Looks like there are more failures.

[ericstj]

Looks like there are more failures.

Yeah I figured. I got a clean Windows Libs build w/ CoreCLR but other flavors need suppressions.

[stephentoub]

Should such a NoWarn be centralized in https://github.com/dotnet/runtime/blob/main/src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems?

[ericstj]

I considered it but the generator was referenced in each project and it made more sense to put this in the same spot the generator was referenced.