[ppc64le] Performance improvements while branching during function calls #90367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l method for ppc64le architecture
ghost
added
the
community-contribution
3 tasks
|
/azp run runtime-community |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
green on ppc |
vargaz
approved these changes
Aug 15, 2023
|
/backport to release/8.0-rc1 |
|
Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5873025608 |
|
@directhex backporting to release/8.0-rc1 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: [ppc64le] Fixed thunk address 8 byte alignment issue
.git/rebase-apply/patch:41: trailing whitespace.
/* We need to align thunks_offset to 8 byte boundary, hence allocating first 8 bytes
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M src/mono/mono/mini/mini-ppc.c
M src/mono/mono/mini/mini-ppc.h
Falling back to patching base and 3-way merge...
Auto-merging src/mono/mono/mini/mini-ppc.h
Auto-merging src/mono/mono/mini/mini-ppc.c
CONFLICT (content): Merge conflict in src/mono/mono/mini/mini-ppc.c
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 [ppc64le] Fixed thunk address 8 byte alignment issue
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@directhex an error occurred while backporting to release/8.0-rc1, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
|
@vargaz @directhex |
|
Why did the auto backport fail ? |
carlossanlop
added
Servicing-approved
Weird, dunno, I didn't expect it to fail. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance improvements has been made while branching during function calls by using bcctrl instruction instead of blrl instruction.