Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-rc1] Fix support for non-public default constructors using JsonIncludeAttribute #90615

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 15, 2023

Backport of #90612 to release/8.0-rc1

/cc @eiriktsarpalis

Customer Impact

The PR in #88452 added support for non-public constructors annotated with the JsonConstructor attribute. The implementation missed out default constructor support in the reflection-based serializer as reported by this customer issue.

Testing

Added unit tests covering the relevant scenario.

Risk

Low. Relatively straightforward changes made to the reflection resolver.

@eiriktsarpalis eiriktsarpalis added the Servicing-consider Issue for next servicing release review label Aug 15, 2023
@eiriktsarpalis eiriktsarpalis added this to the 8.0.0 milestone Aug 15, 2023
@eiriktsarpalis eiriktsarpalis self-assigned this Aug 15, 2023
@ghost
Copy link

ghost commented Aug 15, 2023

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90612 to release/8.0-rc1

/cc @eiriktsarpalis

Customer Impact

The PR in #88452 added support for non-public constructors annotated with the JsonInclude attribute. The implementation missed out default constructor support in the reflection-based serializer as reported by this customer issue.

Testing

Added unit tests covering the relevant scenario.

Risk

Low. Relatively straightforward changes made to the reflection resolver.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Text.Json

Milestone: -

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 16, 2023
@carlossanlop
Copy link
Member

This was approved yesterday.

@carlossanlop carlossanlop merged commit d29067b into release/8.0-rc1 Aug 16, 2023
104 of 109 checks passed
@carlossanlop carlossanlop deleted the backport/pr-90612-to-release/8.0-rc1 branch August 16, 2023 14:38
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants