Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] Fix gcroot SOS command on arm/arm64 #90658

Merged
merged 1 commit into from
Aug 16, 2023
Merged

[release/8.0] Fix gcroot SOS command on arm/arm64 #90658

merged 1 commit into from
Aug 16, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 16, 2023 •
edited by mikem8361
Loading

Backport of #90650 to release/8.0

/cc @mikem8361

Customer Impact

The SOS command !gcroot on in a simple customer suppled test app SEGSIGV's in the DAC making the command useless.

Testing

Manually with the customer's test app

Risk

Low. Only affects arm32/arm64 DAC.

@mikem8361
Fix gcroot SOS command on arm/arm64
6e90982 
Faulted in DAC because the HelperMethodFrame's REGDISPLAY CurrentContextPointers were not initialized correctly.

Fixes issue dotnet/diagnostics#3726
@mikem8361 mikem8361 self-assigned this Aug 16, 2023
@mikem8361 mikem8361 requested a review from hoyosjs August 16, 2023 05:59
@build-analysis build-analysis bot mentioned this pull request Aug 16, 2023
Closed
@carlossanlop
Copy link
Member

@mikem8361 can you please fill out the template? cc @jeffschwMSFT for approval when ready.

PS: Don't press the "Update branch" button, or the CI will restart. Ping me when ready to merge and I can bypass the restriction and merge it.

@mikem8361
Copy link
Member

@carlossanlop, the template has been updated.

@carlossanlop carlossanlop added the Servicing-consider Issue for next servicing release review label Aug 16, 2023
@carlossanlop
Copy link
Member

Another question, @mikem8361: Did you intend to send it to the release/8.0 branch? Asking because it means it would go to RC2, not RC1.

  • If that is expected, then we only need @jeffschwMSFT approval.

  • If not, then please retarget the PR to the release/8.0-rc1 branch (you can do it by editing the PR title), and fill out the template with the info requested yesterday in my RC2 snap email, then please send an email to Tactics requesting approval.

@mikem8361
Copy link
Member

RC2 (release/8.0) was what I intended so I wouldn't have to go through any more hoops.

/cc: @jeffschwMSFT

jeffschwMSFT
jeffschwMSFT approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. merge when ready

@carlossanlop carlossanlop mentioned this pull request Aug 16, 2023
Closed
@carlossanlop
Copy link
Member

carlossanlop commented Aug 16, 2023 •
edited
Loading

Failures unrelated:

@carlossanlop carlossanlop merged commit 9dc05ee into release/8.0 Aug 16, 2023
104 of 112 checks passed
@carlossanlop carlossanlop deleted the backport/pr-90650-to-release/8.0 branch August 16, 2023 20:12
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

@hoyosjs hoyosjs hoyosjs approved these changes

Assignees

@mikem8361 mikem8361

Labels
area-VM-coreclr Servicing-consider Issue for next servicing release review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlossanlop @mikem8361 @jeffschwMSFT @hoyosjs