-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding PACKAGE.md to System.Runtime.Caching package #90701
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned HongGit
Aug 16, 2023
StephenMolloy
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly boilerplate and sourced from existing documentation. A few suggestions. Otherwise, lgtm.
radical
pushed a commit
that referenced
this pull request
Aug 21, 2023
* Adding PACKAGE.md to System.Runtime.Caching package * add Remarks * move PACKAGE.md to src folder * update per PR feedback * add important block
radical
added a commit
that referenced
this pull request
Aug 23, 2023
* Bump main version to 9.0-alpha1 * Try bumping SdkBandVersion * Bump the emscripten transport package * Fix typo * Update TFM to net9.0, minimum to net8.0, use RC1 nightly for SDK to avoid regressions in .NET 8.0 targets and clean up .NET 8->.NET 9 API compat baselining. * Add compat suppressions for removed EOL TFM assets that will not be in the 9.0 variants of the packages. * PR feedback * Fix ILLink errors in the build. * Update Versions.props * PR feedback * Don't use non-portable rids in src/tests infra * Fix restore for Microsoft.NETCore.App.Runtime-based sfxprojs * Fix libs build and expand where we set RunAnalyzers * PR feedback * Try fixing the package testing. * Fix remaining restore issues. * Patch preserialized resources to account for the major version bump (convert Version=8.0.0.0 to Version=9.0.0.0) * Remove explicit hard-coding of net6.0 package testing * Convert more references to net8.0 to net9.0 * Revert TFM changes * Add workaround for RequiresPreviewFeatures and regenerate SLE compat suppressions. * [wasm] Unpin sdk version, and change channel to 9.0 for WBT * Revert "[wasm] Unpin sdk version, and change channel to 9.0 for WBT" This reverts commit be2c615. * Patch preserialized resources to account for the major version bump (convert Version=8.0.0.0 to Version=9.0.0.0) * Suppress EventLog package validation failures to get allconfigurations passing. * Fix queue count in rate limiters (#90810) * Adding PACKAGE.md to System.Runtime.Caching package (#90701) * Adding PACKAGE.md to System.Runtime.Caching package * add Remarks * move PACKAGE.md to src folder * update per PR feedback * add important block * [wasm] Unpin sdk version, and change channel to 9.0 for WBT * workloads-testing.targets: Ignore standard error/warning formats Prompted by the following getting caught as a warning, and converted to an error: ``` EXEC : error : dotnet-install: Failed to check the disk space. Installation will continue, but it may fail if you do not have [D:\a\_work\1\s\src\mono\wasm\Wasm.Build.Tests\Wasm.Build.Tests.csproj] enough disk space. dotnet-install: Extracting the archive. ``` * Force AssemblyVersion * Revert changes. * Remove the SLE suppressions again. * Fix 9.0->8.0 replace * Revert "Fix queue count in rate limiters (#90810)" This reverts commit 1b9e4e3. * Fix formatting * Update Version.Details.xml for xlifftasks to try to fix prebuilt error. --------- Co-authored-by: Larry Ewing <lewing@microsoft.com> Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com> Co-authored-by: Ankit Jain <radical@gmail.com> Co-authored-by: Brennan <brecon@microsoft.com> Co-authored-by: Hong Li <hongli@microsoft.com>
7 tasks
ViktorHofer
pushed a commit
that referenced
this pull request
Sep 18, 2023
* Adding PACKAGE.md to System.Runtime.Caching package * add Remarks * move PACKAGE.md to src folder * update per PR feedback * add important block
ghost
locked as resolved and limited conversation to collaborators
Sep 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.