Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Do not set fetch depth on source-build #90703

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Aug 16, 2023

The nuget feed setup that happens in an official build will alter the local working copy, causing source build to attempt a stash. Stashes of changes in shallow cloned repos aren't currently supported by arcade.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 16, 2023
@ghost ghost assigned mmitche Aug 16, 2023
@mmitche mmitche changed the title Do not set fetch depth on source-build [release/8.0] Do not set fetch depth on source-build Aug 16, 2023
@mmitche
Copy link
Member Author

mmitche commented Aug 16, 2023

/backport to release/8.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5884524039

@lewing
Copy link
Member

lewing commented Aug 16, 2023

/backport to main

@github-actions
Copy link
Contributor

Started backporting to main: https://github.com/dotnet/runtime/actions/runs/5884533817

@mmitche
Copy link
Member Author

mmitche commented Aug 16, 2023

I don't think that main will need this in the long run, since we aim to get rid of the shallow clone, but it's not bad to have.

@mmitche mmitche merged commit 68213d0 into dotnet:release/8.0 Aug 16, 2023
5 of 14 checks passed
@lewing
Copy link
Member

lewing commented Aug 16, 2023

I don't think that main will need this in the long run, since we aim to get rid of the shallow clone, but it's not bad to have.

Yeah I just figured it couldn't hurt

@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants