Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-rc1] Fix PortableRuntimeIdentifierGraph.json not found during runtime repo source build #90714

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 17, 2023

Backport of #90695 to release/8.0-rc1

/cc @elinor-fung

Fixes dotnet/source-build#3592

Customer Impact

Source build fails in the stage 2 bootstrapping scenario

Testing

CI build (internal)

Risk

Low

@ghost
Copy link

ghost commented Aug 17, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90695 to release/8.0-rc1

/cc @elinor-fung

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Aug 17, 2023
@carlossanlop
Copy link
Member

@elinor-fung ping me when this is ready to merge and I'll merge it.

@carlossanlop
Copy link
Member

carlossanlop commented Aug 17, 2023

I see you sent an email to Tactics requesting approval. While this is an infra change (it's tell mode) I can also wait for the approval if it is really impactful and we need it explicitly approved. Let me know.

Edit: Nevermind, I just saw Tactics approved. This is good to merge.

@carlossanlop carlossanlop merged commit a9b1d3c into release/8.0-rc1 Aug 17, 2023
173 of 175 checks passed
@carlossanlop carlossanlop deleted the backport/pr-90695-to-release/8.0-rc1 branch August 17, 2023 15:25
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants