Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Pin sdk version to 8.0.100-rc.1.23415.5 for workload testing #90747

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

radical
Copy link
Member

@radical radical commented Aug 17, 2023

.. because dotnet-install --channel 8.0 is returning 9.0-alpha sdks right now.

Fixes #90742
Fixes #90743

.. because `dotnet-install --channel 8.0` is returning 9.0-alpha sdks right now.
@radical radical added the arch-wasm WebAssembly architecture label Aug 17, 2023
@ghost
Copy link

ghost commented Aug 17, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

.. because dotnet-install --channel 8.0 is returning 9.0-alpha sdks right now.

Author: radical
Assignees: -
Labels:

arch-wasm

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 17, 2023
@ghost ghost assigned radical Aug 17, 2023
@radical radical requested a review from lewing August 17, 2023 15:17
@lewing
Copy link
Member

lewing commented Aug 17, 2023

need to pin in the release branches too right?

@radical
Copy link
Member Author

radical commented Aug 17, 2023

/backport to release/8.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5892810023

@radical radical added area-Build-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 17, 2023
@lewing
Copy link
Member

lewing commented Aug 17, 2023

And we'll want to unpin in #90558 (and fix the channel) once this lands

@radical
Copy link
Member Author

radical commented Aug 17, 2023

This needs to wait for at least the WBT runs for browser-wasm, and wasi-wasm.

@radical
Copy link
Member Author

radical commented Aug 17, 2023

WBT passed. Merging this to get CI green.

@radical radical merged commit a9a6c20 into dotnet:main Aug 17, 2023
@radical radical deleted the pin-wbt-sdk branch August 17, 2023 17:11
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasm] WBT for wasi broken on main [wasm] WBT broken on main
2 participants