-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] [JIT] ARM64 - Temporary fix for ldp/stp optimizations - with test fix #90758
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #90700 to release/8.0 /cc @TIHan Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. please get a code review and we can merge
@dotnet/jit-contrib this is ready - was already reviewed before |
CI errors are known issues. |
Backport of #90700 to release/8.0
/cc @TIHan
Customer Impact
JIT produces bad code-gen which leads to invalid results.
Testing
Two tests were added to ensure we get the correct results.
Risk
Risk is very low as the likelihood of encountering the original bug was already very low. The change only impacts the original scenario.
Description
Resolves #85765
With the latest, the code-gen is quite different from what was reported in the issue, and therefore doesn't reproduce. But the issue still exists and is able to be reproduced by a different sample: