Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about IlcScanReflection to the native aot docs #90765

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Aug 17, 2023

Fixes #90171

@ghost
Copy link

ghost commented Aug 17, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #90171

Author: jkotas
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

@@ -248,7 +248,7 @@ The .NET Foundation licenses this file to you under the MIT license.
<IlcArg Include="@(RuntimeHostConfigurationOption->'--runtimeknob:%(Identity)=%(Value)')" />
<IlcArg Include="--runtimeknob:RUNTIME_IDENTIFIER=$(RuntimeIdentifier)" />
<IlcArg Condition="$(ServerGarbageCollection) == 'true'" Include="--runtimeopt:gcServer=1" />
<IlcArg Condition="$(IlcGenerateCompleteTypeMetadata) == 'true' and $(IlcDisableReflection) != 'true'" Include="--completetypemetadata" />
<IlcArg Condition="$(IlcGenerateCompleteTypeMetadata) == 'true'" Include="--completetypemetadata" />
Copy link
Member Author

@jkotas jkotas Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed anymore since IlcGenerateCompleteTypeMetadata is off by default.

@jkotas jkotas added the documentation Documentation bug or enhancement, does not impact product or test code label Aug 17, 2023
@jkotas
Copy link
Member Author

jkotas commented Aug 17, 2023

cc @NCLnclNCL

Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jkotas jkotas merged commit 8848123 into dotnet:main Aug 18, 2023
104 of 109 checks passed
@jkotas jkotas deleted the issue-90171 branch August 18, 2023 19:58
@ghost ghost locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-NativeAOT-coreclr documentation Documentation bug or enhancement, does not impact product or test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need add optimize Document for IlcScanReflection
2 participants