Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][debugger] Trying to fix MT debugging experience. #90771

Closed
wants to merge 6 commits into from
Closed

[wasm][debugger] Trying to fix MT debugging experience. #90771

wants to merge 6 commits into from

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Aug 17, 2023 •
edited
Loading

I'm doing this workaround to avoid memory allocation while debugging a MT wasm app, it looks like there is some failure while updating the memory in all the workers while some of them are paused.
This will fix the CI and also improve the customer experience.

@ghost ghost assigned thaystg Aug 17, 2023
@ghost
Copy link

ghost commented Aug 17, 2023

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: thaystg
Assignees: thaystg
Labels:

area-Debugger-mono
Milestone: -

@thaystg
Copy link
Member Author

thaystg commented Aug 17, 2023

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@thaystg
Copy link
Member Author

thaystg commented Aug 17, 2023

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@thaystg
Copy link
Member Author

thaystg commented Aug 17, 2023

First try passed the MT debugger tests.

@thaystg
Copy link
Member Author

thaystg commented Aug 17, 2023

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@thaystg
Copy link
Member Author

thaystg commented Aug 17, 2023

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@thaystg
Copy link
Member Author

thaystg commented Aug 17, 2023

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@thaystg
Copy link
Member Author

thaystg commented Aug 18, 2023

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@thaystg
Copy link
Member Author

thaystg commented Aug 18, 2023

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@thaystg
Copy link
Member Author

thaystg commented Aug 18, 2023

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@thaystg thaystg marked this pull request as ready for review August 18, 2023 12:50
@thaystg thaystg requested a review from radical August 18, 2023 12:50
@thaystg
Copy link
Member Author

thaystg commented Aug 18, 2023

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@thaystg
Copy link
Member Author

thaystg commented Aug 18, 2023

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical added the arch-wasm WebAssembly architecture label Aug 18, 2023
@ghost
Copy link

ghost commented Aug 18, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

I'm doing this workaround to avoid memory allocation while debugging a MT wasm app, it looks like there is some failure while updating the memory in all the workers while some of them are paused.
This will fix the CI and also improve the customer experience.

Author: thaystg
Assignees: thaystg
Labels:

arch-wasm, area-Debugger-mono
Milestone: -

@radical radical requested review from kg and pavelsavara August 18, 2023 16:08
@thaystg
Copy link
Member Author

thaystg commented Oct 16, 2023

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Oct 16, 2023
Closed
@thaystg
Copy link
Member Author

thaystg commented Oct 17, 2023

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 17, 2023
Open
Open
@thaystg
Copy link
Member Author

thaystg commented Oct 26, 2023

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Oct 26, 2023
Closed
@thaystg
Copy link
Member Author

thaystg commented Oct 27, 2023

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara mentioned this pull request Nov 2, 2023
Merged
@thaystg thaystg closed this Nov 7, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pavelsavara pavelsavara pavelsavara left review comments

@radical radical Awaiting requested review from radical

@kg kg Awaiting requested review from kg

Assignees

@thaystg thaystg

Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thaystg @pavelsavara @radical