Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] Update browser template to use Wasm SDK #90871

Merged
merged 18 commits into from
Aug 23, 2023
Merged

[browser] Update browser template to use Wasm SDK #90871

merged 18 commits into from
Aug 23, 2023

Conversation

maraf
Copy link
Member

@maraf maraf commented Aug 21, 2023 •
edited
Loading

  • Update browser template to use Wasm SDK
  • Remove index.html from html-path (open eg. http://localhost:5073/ instead of http://localhost:5073/index.html)
  • Remove README from template
  • Add support for console forward to (WasmAppHost's) DevServer
  • Cancel cancellation token passed around WasmAppHost when cancel key is pressed

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Aug 21, 2023
@maraf maraf added this to the 9.0.0 milestone Aug 21, 2023
@maraf maraf self-assigned this Aug 21, 2023
@ghost
Copy link

ghost commented Aug 21, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Update browser template to use Wasm SDK
  • Remove index.html from html-path (open eg. http://localhost:5073/ instead of http://localhost:5073/index.html)
  • Add support for console forward to (WasmAppHost's) DevServer
  • Cancel cancellation token passed around WasmAppHost when cancel key is pressed
Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-Build-mono, os-browser
Milestone: 9.0.0

@maraf maraf requested a review from radical August 23, 2023 12:24
radical
radical approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And great work getting to this point!! 👍

@radical radical merged commit 819e288 into dotnet:main Aug 23, 2023
@maraf maraf deleted the WasmSdkTemplate2 branch August 24, 2023 05:58
@maraf
Copy link
Member Author

maraf commented Aug 24, 2023

/backport to release/8.0

@github-actions
Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5960721844

@github-actions github-actions bot mentioned this pull request Aug 24, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

@kg kg Awaiting requested review from kg

Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@maraf @radical