Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF] Use the major version for the net_.0 version in create mono dotnet step #91452

Merged
merged 5 commits into from
Sep 5, 2023

Conversation

LoopedBard3
Copy link
Member

@LoopedBard3 LoopedBard3 commented Sep 1, 2023

Use the major version from the Versions.props for the net_.0 version in create mono dotnet. This is recently broken due to the Major version update to 9 while we have 8 hardcoded.

Test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2257981&view=results

@ghost
Copy link

ghost commented Sep 1, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Use the major version from the Versions.props for the net_.0 version in create mono dotnet. This is recently broken due to the Major version update to 9 while we have 8 hardcoded.

Test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2257289&view=results

Author: LoopedBard3
Assignees: LoopedBard3
Labels:

area-Infrastructure-mono

Milestone: -

Copy link
Contributor

@cincuranet cincuranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this where the framework variable from parameters should be used?

@LoopedBard3
Copy link
Member Author

Isn't this where the framework variable from parameters should be used?

Updated to use this variable. Something of note, the framework here does not seem to have any actual impact on test framework stuff since we get that from the channel_map.

@cincuranet cincuranet merged commit 790c4c0 into dotnet:main Sep 5, 2023
@LoopedBard3 LoopedBard3 deleted the PerfFixCreateMonoDotnet branch September 6, 2023 21:42
@ghost ghost locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants