Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the assert to include Vector64/Vector128 CreateScalar #91504

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

kunalspathak
Copy link
Member

The assert was missing CreateScalar intrinsic entries.

Fixes: #91336

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 2, 2023
@ghost ghost assigned kunalspathak Sep 2, 2023
@ghost
Copy link

ghost commented Sep 2, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

The assert was missing CreateScalar intrinsic entries.

Fixes: #91336

Author: kunalspathak
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@kunalspathak
Copy link
Member Author

superpmi-* jobs are failing because the collection is not available for the guid. I have kicked off another superpmi collection run.

@kunalspathak
Copy link
Member Author

/azp run runtime-coreclr superpmi-diffs, runtime-coreclr superpmi-replay

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kunalspathak
Copy link
Member Author

@dotnet/jit-contrib

@kunalspathak
Copy link
Member Author

/azp run runtime-coreclr superpmi-diffs

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kunalspathak
Copy link
Member Author

can someone review this? should be quick.

@kunalspathak
Copy link
Member Author

Failures seems to be known repository issue. https://github.com/dotnet/runtime/pull/91504/checks?check_run_id=16584913496

@kunalspathak kunalspathak merged commit c53e4dc into dotnet:main Sep 7, 2023
@kunalspathak kunalspathak deleted the createscalar branch September 7, 2023 14:36
@ghost ghost locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.