Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] ENVIRONMENT_IS_WEB is also true on WebWorker #91589

Merged
merged 2 commits into from
Sep 5, 2023
Merged

[browser] ENVIRONMENT_IS_WEB is also true on WebWorker #91589

merged 2 commits into from
Sep 5, 2023
+4 −4

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Sep 5, 2023 •
edited
Loading

ENVIRONMENT_IS_WEB impacts noExitRuntime among other things.

Fixes #91528

This may need Net8 backport

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Sep 5, 2023
@pavelsavara pavelsavara added this to the 8.0.0 milestone Sep 5, 2023
@pavelsavara pavelsavara requested a review from maraf September 5, 2023 12:32
@pavelsavara pavelsavara self-assigned this Sep 5, 2023
@ghost
Copy link

ghost commented Sep 5, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #91528

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 8.0.0

@pavelsavara
Copy link
Member Author

In MT build, when we are on worker, does noExitRuntime need to stay false ?

@lambdageek

@lambdageek
Copy link
Member

In MT build, when we are on worker, does noExitRuntime need to stay false ?

@lambdageek

yes I think so

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Sep 5, 2023
Open
Closed
Open
Open
Closed
@pavelsavara
Copy link
Member Author

All failures are known and linked above.

@pavelsavara pavelsavara merged commit 889133d into dotnet:main Sep 5, 2023
@pavelsavara
Copy link
Member Author

/backport to release/8.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6088039159

@github-actions github-actions bot mentioned this pull request Sep 5, 2023
Merged
@build-analysis build-analysis bot mentioned this pull request Sep 5, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 5, 2023
@pavelsavara pavelsavara deleted the browser_detect_browser_worker branch September 2, 2024 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilonatommy ilonatommy ilonatommy approved these changes

@maraf maraf Awaiting requested review from maraf

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@kg kg Awaiting requested review from kg

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

[browser] ENVIRONMENT_IS_WEB is false when dotnet started on worker, leads to exit(0)
3 participants
@pavelsavara @lambdageek @ilonatommy