Fix handling of --help in the build-commons.sh
#91590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--help` was not recognized in that script because double dashes were converted to single ones before processing the options. That causes e.g. the src/test/build.sh to not to recognize the `--help` option, so it instead starts building the tests. This change fixes it
|
Tagging subscribers to this area: @hoyosjs Issue DetailsThe This change fixes it.
|
jkoritzinsky
approved these changes
Sep 5, 2023
jkotas
approved these changes
Sep 5, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--helpwas not recognized in that script because double dashes were converted to single ones before processing the options. That causes e.g. the src/test/build.sh to not to recognize the--helpoption, so it instead starts building the tests.This change fixes it.