Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Split the informational version on both SemVer2 separators when calculating TFM #91760

Merged
merged 1 commit into from
Sep 8, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ public static class AnalyzerConfigOptionsExtensions
// Parse from the informational version as that is the only version that always matches the TFM version
// even in debug builds.
private static readonly Version ThisAssemblyVersion = Version.Parse(
typeof(IncrementalGeneratorInitializationContextExtensions).Assembly
.GetCustomAttribute<AssemblyInformationalVersionAttribute>().InformationalVersion.Split('-')[0]);
typeof(AnalyzerConfigOptionsExtensions).Assembly
.GetCustomAttribute<AssemblyInformationalVersionAttribute>().InformationalVersion.Split('-', '+')[0]);

public static TargetFrameworkSettings GetTargetFrameworkSettings(this AnalyzerConfigOptions options)
{
Expand Down