Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start running test added in #89061 #91780

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Start running test added in #89061 #91780

merged 4 commits into from
Sep 15, 2023

Conversation

MichalStrehovsky
Copy link
Member

GitHub_73658.cs added in #89061 was lacking a csproj so we were not actually running it.
GitHub_78865.cs added in the same PR is an exact copy of StaticVirtualsAndMethodConstraintsAndDefaultImplementation.cs that was added in the same PR. It also lacked a csproj. I'm deleting it instead of adding csproj.

This is an exact copy of StaticVirtualsAndMethodConstraintsAndDefaultImplementation.cs
@ghost ghost assigned MichalStrehovsky Sep 8, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 8, 2023
@MichalStrehovsky MichalStrehovsky added area-TypeSystem-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 8, 2023
@MichalStrehovsky
Copy link
Member Author

Turns out GitHub_73658.cs is also a dupe, of GetInterfaceMapWithStaticVirtualsAndConstraints.cs this time. So deleting that one too.

@jkotas jkotas merged commit a751151 into main Sep 15, 2023
99 checks passed
@jkotas jkotas deleted the MichalStrehovsky-patch-1 branch September 15, 2023 21:01
@ghost ghost locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants