Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] dumpwriterelf: increase buffer to fit a RHEL8 arm64 page. #91953

Merged
merged 2 commits into from
Sep 14, 2023
Merged

[release/8.0] dumpwriterelf: increase buffer to fit a RHEL8 arm64 page. #91953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fc7130
Limit special diagnostics size region to 4KiB.
tmds Sep 12, 2023
93bf8bf
Merge branch 'release/8.0' into backport/pr-91865-to-release/8.0
carlossanlop Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coreclr/debug/createdump/crashinfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ CrashInfo::GatherCrashInfo(DumpType dumpType)
return false;
}
// Add the special (fake) memory region for the special diagnostics info
MemoryRegion special(PF_R, SpecialDiagInfoAddress, SpecialDiagInfoAddress + PAGE_SIZE);
MemoryRegion special(PF_R, SpecialDiagInfoAddress, SpecialDiagInfoAddress + SpecialDiagInfoSize);
m_memoryRegions.insert(special);
#ifdef __APPLE__
InitializeOtherMappings();
Expand Down
2 changes: 2 additions & 0 deletions src/coreclr/debug/createdump/specialdiaginfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ const uint64_t SpecialDiagInfoAddress = 0x7fff1000;
#endif
#endif

const uint64_t SpecialDiagInfoSize = 0x1000;

struct SpecialDiagInfoHeader
{
char Signature[16];
Expand Down