-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge tests under tracing / Reflection / ReadyToRun / Regressions #92029
Merged
trylek
merged 19 commits into
dotnet:main
from
trylek:MergeTracingReflectionReadyToRunRegressions
Oct 5, 2023
Merged
Merge tests under tracing / Reflection / ReadyToRun / Regressions #92029
trylek
merged 19 commits into
dotnet:main
from
trylek:MergeTracingReflectionReadyToRunRegressions
Oct 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @hoyosjs Issue Detailsnull
|
markples
reviewed
Sep 13, 2023
markples
reviewed
Sep 13, 2023
markples
reviewed
Sep 13, 2023
src/tests/readytorun/coreroot_determinism/coreroot_determinism.csproj
Outdated
Show resolved
Hide resolved
markples
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for continuing to push on this!
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
trylek
force-pushed
the
MergeTracingReflectionReadyToRunRegressions
branch
from
October 1, 2023 21:23
48a32a5
to
46c9efa
Compare
Includes deduplication of two "common" libraries - one under the folder "tracing/common" (renamed to tracing_common) and another under "tracing/eventpipe/common" (renamed to eventpipe_common). Thanks Tomas
This failure was caused by incorrectly making a test out of what is in reality a library used by custom means by the test app (for the purpose of accessing resources). While I believe we should further clean this logic up, this should be good enough to make tests pass. Thanks Tomas
trylek
force-pushed
the
MergeTracingReflectionReadyToRunRegressions
branch
from
October 4, 2023 21:06
2edffc6
to
7ef0822
Compare
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Oct 5, 2023
radical
added a commit
to radical/runtime
that referenced
this pull request
Oct 11, 2023
…ions (dotnet#92029)" This reverts commit 4cbfabe.
clamp03
added a commit
to clamp03/runtime
that referenced
this pull request
Oct 13, 2023
Build error of provider.ilproj test when BuildAsStandalone is true `EXEC : error : No entry point declared for executable` This is due to dotnet#92029 Restore OutputType to Library.
jkotas
pushed a commit
that referenced
this pull request
Oct 17, 2023
Build error of provider.ilproj test when BuildAsStandalone is true `EXEC : error : No entry point declared for executable` This is due to #92029 Restore OutputType to Library.
ghost
locked as resolved and limited conversation to collaborators
Nov 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.