Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasi] Add AOT compiler build to the official build #92095

Merged
merged 11 commits into from
Nov 16, 2023
Merged

[wasi] Add AOT compiler build to the official build #92095

merged 11 commits into from
Nov 16, 2023

Conversation

steveisok
Copy link
Member

No description provided.

@ghost ghost assigned steveisok Sep 14, 2023
@build-analysis build-analysis bot mentioned this pull request Sep 15, 2023
Closed
@vargaz vargaz mentioned this pull request Sep 30, 2023
Merged
@vargaz
Copy link
Contributor

vargaz commented Oct 16, 2023

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 17, 2023
Open
Closed
@lewing lewing closed this Nov 13, 2023
@lewing lewing reopened this Nov 13, 2023
This was referenced Nov 14, 2023
Closed
Closed
lewing

This comment was marked as outdated.

Sign in to view

lewing

This comment was marked as outdated.

Sign in to view

@lewing
Copy link
Member

lewing commented Nov 15, 2023

@directhex I think the remaining issue here might be that the system python we're picking up on windows is 32bit and the libclang is 64bit? Which python is the windows build without emsdk using?

@lewing lewing added this to the 9.0.0 milestone Nov 15, 2023
@directhex
Copy link
Member

@directhex I think the remaining issue here might be that the system python we're picking up on windows is 32bit and the libclang is 64bit? Which python is the windows build without emsdk using?

This analysis seems valid. It's p/invoking (or whatever it's called on Python) from D:\a_work\1\s\artifacts\obj\mono\wasi.wasm.Release\llvm\x64\bin\libclang.dll and https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md#language-and-runtime says it comes with Python 3.9 (which has no x64 Windows builds)

@lewing lewing mentioned this pull request Nov 15, 2023
Open
10 tasks
@lewing
Copy link
Member

lewing commented Nov 15, 2023

Could we use the emsdk python package directly for this step?

@lewing lewing marked this pull request as draft November 16, 2023 00:16
@lewing lewing marked this pull request as ready for review November 16, 2023 00:16
@radical radical mentioned this pull request Nov 16, 2023
Closed
@lewing
Copy link
Member

lewing commented Nov 16, 2023

@microsoft-github-policy-service rerun

@lewing
Copy link
Member

lewing commented Nov 16, 2023

@dotnet-policy-service rerun

@steveisok steveisok mentioned this pull request Nov 16, 2023
Closed
@steveisok steveisok merged commit 1c799ea into dotnet:main Nov 16, 2023
183 of 187 checks passed
@steveisok steveisok deleted the add-wasi-aot-pack branch November 16, 2023 00:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing left review comments

@radical radical radical approved these changes

@vargaz vargaz vargaz approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees

@steveisok steveisok

Labels
area-Build-mono
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@steveisok @vargaz @lewing @directhex @radical