Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs #92180

Merged
merged 8 commits into from
Sep 17, 2023
Merged

Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs #92180

merged 8 commits into from
Sep 17, 2023

Conversation

WeihanLi
Copy link
Contributor

@WeihanLi WeihanLi commented Sep 16, 2023 •
edited
Loading

Update jsonTypeInfo for ReadFromJsonAsAsyncEnumerable

fixes #92179

@WeihanLi
Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs
60e9fc7 
reuse method from ReadFromJsonAsAsyncEnumerable
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 16, 2023
@ghost
Copy link

ghost commented Sep 16, 2023

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

reuse method from HttpContent ReadFromJsonAsAsyncEnumerable

fixes #92179

Author: WeihanLi
Assignees: -
Labels:

area-System.Text.Json
Milestone: -

@WeihanLi WeihanLi marked this pull request as ready for review September 16, 2023 16:06
@WeihanLi WeihanLi marked this pull request as draft September 16, 2023 17:54
@build-analysis build-analysis bot mentioned this pull request Sep 16, 2023
Open
@WeihanLi WeihanLi marked this pull request as ready for review September 17, 2023 00:49
WeihanLi and others added 2 commits September 17, 2023 20:04
@WeihanLi @eiriktsarpalis
Update src/libraries/System.Net.Http.Json/tests/FunctionalTests/HttpC…
420e191 
…lientJsonExtensionsTests.cs

Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
@WeihanLi
Merge branch 'dotnet:main' into patch-1
79d1936
@WeihanLi WeihanLi marked this pull request as draft September 17, 2023 12:06
@WeihanLi WeihanLi marked this pull request as ready for review September 17, 2023 12:32
@WeihanLi
Copy link
Contributor Author

Seemed the failed CI not related
image

eiriktsarpalis
eiriktsarpalis approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eiriktsarpalis eiriktsarpalis merged commit 353d5ea into dotnet:main Sep 17, 2023
@eiriktsarpalis
Copy link
Member

/backport to release/8.0

@github-actions
Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6216259225

@github-actions github-actions bot mentioned this pull request Sep 17, 2023
Merged
@WeihanLi WeihanLi deleted the patch-1 branch September 18, 2023 01:40
@ghost ghost locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees
No one assigned
Labels
area-System.Text.Json community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GetFromJsonAsAsyncEnumerable extension default json serialize option is not the same as GetFromJson
2 participants
@WeihanLi @eiriktsarpalis