Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize capturing lambdas in DependencyContextExtensions and DependencyContextJsonReader #92462

Merged
merged 7 commits into from
Nov 28, 2023
Merged

Optimize capturing lambdas in DependencyContextExtensions and DependencyContextJsonReader #92462

merged 7 commits into from
Nov 28, 2023

Commits on Sep 22, 2023

  1. remove capturing lambda

    @karakasa
    karakasa committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    37b9702 View commit details
    Browse the repository at this point in the history

  2. fix typo

    @karakasa
    karakasa committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    b0f43f6 View commit details
    Browse the repository at this point in the history

  3. fix code style

    @karakasa
    karakasa committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    96792a3 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2023

  1. Optimize capturing lambdas in the Dependency framework 

    `DependencyContextExtensions` and `DependencyContextJsonReader`
originally use lambdas capturing local variables, resulting in unnecessary
allocations.

The PR replaces them with helper functions with static lambdas.

Fix dotnet#87911
    @karakasa
    karakasa committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    ae56eb4 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. move the helper file into the library NS.

    @karakasa
    karakasa committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    90812a7 View commit details
    Browse the repository at this point in the history

  2. revert sln file

    @karakasa
    karakasa committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    5c548e4 View commit details
    Browse the repository at this point in the history

  3. make CreateLibrariesNotNull local function

    @karakasa
    karakasa committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    bcf4bdd View commit details
    Browse the repository at this point in the history