Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] [wasm] Endian fix for Webcil #92495

Merged
merged 3 commits into from
Oct 3, 2023
Merged

[release/8.0] [wasm] Endian fix for Webcil #92495

merged 3 commits into from
Oct 3, 2023

Commits on Sep 22, 2023

  1. [wasm] Endian fix for Webcil 

    'dotnet new blazorwasm' command failed on s390x and was throwing a not implemented exception

The issue was with with the WebCil writer and reader, specific endianness conversions relating to the webcil payload were not implemented for big endian machines.

We considered fixing the generic implementation, but there were only two structures in use: WebcilHeader and WebcilSectionHeader, so it was easier to handle them explicitly.
    @saitama951
    saitama951 authored and github-actions committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    51278d6 View commit details
    Browse the repository at this point in the history

  2. Fix infinite recursion

    @lambdageek
    lambdageek authored and github-actions committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    1dbcc53 View commit details
    Browse the repository at this point in the history

  3. rename var

    @lambdageek
    lambdageek authored and github-actions committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    aaf0ca6 View commit details
    Browse the repository at this point in the history