Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0][wasm][debugger] Support multidimensional indexing of object scheme #92753

Merged

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Sep 28, 2023

Backport of #92630.
This backport is needed to easily backport #92637.

Customer impact
Customers will be able to evaluate multidimensional arrays on objects in the debugger e.g. objInstance[0, 1].

Testing
Unit tests.

Risk
Low.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Sep 28, 2023
@ilonatommy ilonatommy self-assigned this Sep 28, 2023
@ghost
Copy link

ghost commented Sep 28, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92630.
This backport is needed to easily backport #92637.

Customer impact
Customers will be able to evaluate multidimensional arrays on objects in the debugger e.g. objInstance[0].

Testing
Unit tests.

Risk
Low.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

@ilonatommy ilonatommy added the Servicing-consider Issue for next servicing release review label Sep 28, 2023
@ilonatommy ilonatommy added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 2, 2023
@carlossanlop carlossanlop merged commit 8632a75 into dotnet:release/8.0 Oct 3, 2023
17 of 18 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants