Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][android] Fix android extra-platforms by renaming the project name #93109

Conversation

kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented Oct 6, 2023

Description

This PR fixes android extra-platforms by renaming the project name. Bundle attribute package has invalid character -.

2023-10-06T01:07:48.5821858Z /__w/1/s/src/mono/msbuild/android/build/AndroidBuild.targets(271,5): error MSB4018: The "AndroidAppBuilderTask" task failed unexpectedly. [/__w/1/s/src/tests/Loader/classloader/regressions/Loader-classloader-regressions.csproj] [/__w/1/s/src/tests/build.proj]
2023-10-06T01:07:48.5822925Z /__w/1/s/src/mono/msbuild/android/build/AndroidBuild.targets(271,5): error MSB4018: System.Exception: Error: Process returned non-zero exit code: AndroidManifest.xml:2: Tag <manifest> attribute package has invalid character '-'. [/__w/1/s/src/tests/Loader/classloader/regressions/Loader-classloader-regressions.csproj] [/__w/1/s/src/tests/build.proj]
2023-10-06T01:07:48.5823916Z /__w/1/s/src/mono/msbuild/android/build/AndroidBuild.targets(271,5): error MSB4018: AndroidManifest.xml:20: Tag <instrumentation> attribute targetPackage has invalid character '-'. [/__w/1/s/src/tests/Loader/classloader/regressions/Loader-classloader-regressions.csproj] [/__w/1/s/src/tests/build.proj]
2023-10-06T01:07:48.5825153Z /__w/1/s/src/mono/msbuild/android/build/AndroidBuild.targets(271,5): error MSB4018: at Utils.RunProcess(TaskLoggingHelper logger, String path, String args, IDictionary`2 envVars, String workingDir, Boolean ignoreErrors, Boolean silent, MessageImportance debugMessageImportance) in /_/src/tasks/Common/Utils.cs:line 123 [/__w/1/s/src/tests/Loader/classloader/regressions/Loader-classloader-regressions.csproj] [/__w/1/s/src/tests/build.proj]
2023-10-06T01:07:48.5826410Z /__w/1/s/src/mono/msbuild/android/build/AndroidBuild.targets(271,5): error MSB4018: at ApkBuilder.BuildApk(String runtimeIdentifier, String mainLibraryFileName, String monoRuntimeHeaders) in /_/src/tasks/AndroidAppBuilder/ApkBuilder.cs:line 449 [/__w/1/s/src/tests/Loader/classloader/regressions/Loader-classloader-regressions.csproj] [/__w/1/s/src/tests/build.proj]
2023-10-06T01:07:48.5827682Z /__w/1/s/src/mono/msbuild/android/build/AndroidBuild.targets(271,5): error MSB4018: at AndroidAppBuilderTask.Execute() in /_/src/tasks/AndroidAppBuilder/AndroidAppBuilder.cs:line 141 [/__w/1/s/src/tests/Loader/classloader/regressions/Loader-classloader-regressions.csproj] [/__w/1/s/src/tests/build.proj]
2023-10-06T01:07:48.5828627Z /__w/1/s/src/mono/msbuild/android/build/AndroidBuild.targets(271,5): error MSB4018: at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/__w/1/s/src/tests/Loader/classloader/regressions/Loader-classloader-regressions.csproj] [/__w/1/s/src/tests/build.proj]

@kotlarmilos
Copy link
Member Author

/azp run list

@ghost
Copy link

ghost commented Oct 6, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

This PR fixes android extra-platforms by renaming the project name. Bundle attribute package has invalid character -.

Author: kotlarmilos
Assignees: kotlarmilos
Labels:

os-android, area-Infrastructure-mono

Milestone: 9.0.0

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@kotlarmilos
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fanyang-mono
Copy link
Member

Still failing with the same error. Somehow the name didn't seem to be changed.

@kotlarmilos
Copy link
Member Author

Still failing with the same error. Somehow the name didn't seem to be changed.

Actually, project Loader-classloader-generics is invalid as well.

@kotlarmilos
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@kotlarmilos kotlarmilos merged commit 9105586 into dotnet:main Oct 6, 2023
50 of 59 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants