-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MT][browser] Disable new CI failures on library MT tests #93224
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
How often has this run recently, and how often has it failed? |
It failed "silently" for me. I have not noticed that there is "organge" lane. I want it to really fail when I do |
'runtime-wasm' will be red then. |
Right, that's what we want to anything that was not already marked active issue by Ilona in #91536. Am I missing something ? |
This PR needs adding a blocking for |
Has the job been green for few weeks when there were no PR introduced mt failures? That's what I'm talking about. It shouldn't randomly fail, else we would start getting merges on red and failures getting ignored because users aren't sure whether the failures are expected. A red pipeline on PRs that did not introduce mt failures would be counterproductive. |
Then it hasn't been green/stable for few weeks. |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't merge this yet. We should have couple of weeks worth of builds where the job has been green, before we merge.
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
In that case we need to make the test run much more often. What we have now is useless waiting without any observability. Do you have any proposal @radical ? |
The test failures are observable, just that they won't show up as failures in github. Open the azdo build and you can see the failures, and all the details. |
Let's merge at least these fixes for now. Failures are unrelated. |
👍 Please update the PR title, and description to match. |
Also, please open an issue for the error that is unrelated, and isn't being flagged by |
Block
Wasm.Browser.Threads.Minimal.Sample.csproj
for MTMove issues connected with MT exclusions to be blocked only in MT mode.
Add project exclusion for Microsoft.Extensions.DependencyInjection.Tests
Fixing
fail: [out of order message from the browser]: http://127.0.0.1:33323/_framework/dotnet.js 2 WebSocket connection to 'ws://127.0.0.1:33323/_framework/dotnet.native.worker.js/console' failed: Error during WebSocket handshake: Unexpected response code: 404