[browser] Trim globalization code #93473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsIn the measurements a sample WASM app is used with added a few Globalization method calls. Goal:
Changes:
Results:
Quoted sizes of
|
vitek-karas
reviewed
Oct 13, 2023
src/libraries/System.Private.CoreLib/src/ILLink/ILLink.Substitutions.Browser.xml
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/ILLink/ILLink.Substitutions.Browser.xml
Outdated
Show resolved
Hide resolved
maraf
reviewed
Oct 16, 2023
vitek-karas
reviewed
Oct 18, 2023
This was referenced Oct 18, 2023
radical
reviewed
Oct 19, 2023
...System.Diagnostics.Tracing/tests/TrimmingTests/System.Diagnostics.Tracing.TrimmingTests.proj
Outdated
Show resolved
Hide resolved
This was referenced Oct 20, 2023
liveans
pushed a commit
to liveans/dotnet-runtime
that referenced
this pull request
Nov 9, 2023
* Correct trimming errors. * Feedback * Fix WBT * Allow trimming Settings class on Unix. * Feature switches setting matter, not properties. Improve the approach to WBT fix. * Users set properties, not features, so this is what we should test. * Revert. * `DebuggerSupport` is false by default * `EventSourceSupport` is trimmed when not enabled. * Fix `WasmTestOnBrowser` scenario lib tests. * Fixing another batch of lib failures. * Fix `System.Runtime` tests + partial feedback. * @radical's feedback * Moving common properties to manifest.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the measurements a sample WASM app is used with added a few Globalization method calls.
Goal:
Changes:
System.Globalization.Hybridfeature switch substitution,_GetWasmGenerateAppBundleDependenciesthat was setting MsBuild properties for feature switches used to be run afterIILinktask. From this reason, all unset MsBuild properties that were planned to be substituted when they are "false" were ignored. Initial feature switches setup was copied fromruntime/src/mono/nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets
Line 65 in e8b8a77
WasmApp.targets. They were changed to property switches.DebuggerTypeProxyAttributeTestsandDebuggerVisualizerAttributeTestsneed to setDebuggerSupport=truein order not to have the debugger code trimmed:runtime/docs/workflow/trimming/feature-switches.md
Line 11 in 04ede0d
The test used to expect the debugger code to be preserved even though it did not set the property to
true.Same thing for
EventSourcePropertyValueTest,EventSourceManifestTest.Results:
Quoted sizes of
AppBundlesare not brotlied.