Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed stoppingToken to cancellationToken. #93546

Closed
wants to merge 1 commit into from
Closed

Renamed stoppingToken to cancellationToken. #93546

wants to merge 1 commit into from

Conversation

Sixaxys317
Copy link

Renamed stoppingToken to cancellationToken where relevant.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 16, 2023
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Oct 16, 2023

Tagging subscribers to this area: @dotnet/area-extensions-hosting
See info in area-owners.md if you want to be subscribed.

Issue Details

Renamed stoppingToken to cancellationToken where relevant.

Author: Sixaxys317
Assignees: -
Labels:

new-api-needs-documentation, area-Extensions-Hosting, community-contribution
Milestone: -

@Sixaxys317
Copy link
Author

@dotnet-policy-service agree

@stephentoub
Copy link
Member

Thanks, but changing parameter names in exported surface area is a breaking change.

@Sixaxys317
Copy link
Author

Thanks for quick response!

Aha, I didn't know that. It was worth a shot to fix the inconsistency in the naming of the parameter.

@Sixaxys317 Sixaxys317 closed this Oct 16, 2023
@build-analysis build-analysis bot mentioned this pull request Oct 16, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
area-Extensions-Hosting community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sixaxys317 @stephentoub