Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DictionaryKeyTypeNotSupported error message #93553

Conversation

naeemaei
Copy link
Contributor

Add extra details about the cause of dictionary key serialization NotSupportedException

Fix #93406

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 16, 2023
@ghost
Copy link

ghost commented Oct 16, 2023

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Add extra details about the cause of dictionary key serialization NotSupportedException

Fix #93406

Author: naeemaei
Assignees: -
Labels:

area-System.Text.Json

Milestone: -

@naeemaei naeemaei marked this pull request as ready for review October 16, 2023 15:25
Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
@eiriktsarpalis
Copy link
Member

Thanks!

@eiriktsarpalis eiriktsarpalis merged commit ccc475e into dotnet:main Oct 16, 2023
106 of 109 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message for dictionary key converters not implementing ReadAsPropertyName/WriteAsPropertyName.
2 participants