Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pushd/popd Calls With -S/-B CMake Flags in the Build System #94353

Merged
merged 7 commits into from
Nov 29, 2023
Merged

Replace pushd/popd Calls With -S/-B CMake Flags in the Build System #94353

merged 7 commits into from
Nov 29, 2023

Commits on Nov 2, 2023

  1. Successfully replaced pushd/popd with CMake's -S/-B in gen-buildsys.sh 

    for native and clr. Now, looking into removing other instances if
    possible.
    @ivdiazsa
    ivdiazsa committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f2ee179 View commit details
    Browse the repository at this point in the history

  2. Removed redundant pushd/popd in src/native/libs/build-native.cmd

    @ivdiazsa
    ivdiazsa committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    c0635f4 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Experimenting with removing 'pushd/popd' for Wasm/Wasi.

    @ivdiazsa
    ivdiazsa committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    01ec2a2 View commit details
    Browse the repository at this point in the history

  2. Restored pushd/popd to eng/native/build-commons.sh because it is 

    actually not directly related to CMake.
    @ivdiazsa
    ivdiazsa committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    a4ee72f View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Merge branch 'main' into s-and-b

    @ivdiazsa
    ivdiazsa committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    9fedd63 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Add explicit exit code to gen-buildsys.sh 

    Make sure we don't forget to return the cmake exist code, see #95408.
    @akoeplinger
    akoeplinger authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    360a3db View commit details
    Browse the repository at this point in the history

  2. Replace with comment instead

    @akoeplinger
    akoeplinger authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    0659f6b View commit details
    Browse the repository at this point in the history