Provide System.IO.Pipelines package readme #94372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsFill out details for the See #92228
|
davidfowl
reviewed
Nov 6, 2023
Comment on lines
+45
to
+53
| for (int i = 0; i < input.Length; i++) | ||
| { | ||
| Memory<byte> memory = writer.GetMemory(1); | ||
| memory.Span[0] = input[i]; | ||
| writer.Advance(1); | ||
|
|
||
| // Make the data available to the PipeReader. | ||
| await writer.FlushAsync(); | ||
| } |
There was a problem hiding this comment.
This example looks really inefficient.
There was a problem hiding this comment.
I tried to create a simple implementation of the workings of Pipe but have no further experience with it in practice.
The example that is part of the conceptual documentation link (https://learn.microsoft.com/en-us/dotnet/standard/io/pipelines#pipe-basic-usage) requires quite a large explanation, which didn't seem appropriate for the readme of the package itself.
I'm open for suggestions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fill out details for the
System.IO.PipelinesNuGet package readme.See #92228