-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update branding to 8.0.1 #94484
Update branding to 8.0.1 #94484
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue Detailsnull
|
@carlossanlop Do you need to turn off package builds for packages that do not have approved fixes? |
@mmitche No, we now reset the packages from building in the staging branches on code-complete day, right before I flow staging into internal. We decided to do that because usually the branding day happens many days before GA day for the previous servicing version. And when that happens, the CI gets flooded with failures due to the packages not being found in nuget. The current servicing release is exactly one of those cases: Today is branding on the 7th for 8.0.1, but 8.0.0 (GA) goes live until November 14th. So we want to avoid failures for a full week. |
@lewing @radical are the wasm CI failures related to branding or can they be addressed in a separate PR? Output example (expand)
|
It looks like now wasm is facing the same problem I described in my previous comment, which we usually only see in regular libraries tests. |
Chatted with @radical, the wasm failure is pre-existing. |
The other failure is a Quic timeout:
If I see it again I'll open an issue, cc @dotnet/ncl. |
We can perhaps roll back to previous version via tag e.g. |
No description provided.