Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the useful constant values in TimeSpan #94627

Closed
wants to merge 1 commit into from

Conversation

IDisposable
Copy link
Contributor

Make the useful constants that TimeSpan has internally declare public because they're rooted in hard reality and not changeable, and quite useful elsewhere.
Fixes #94545

Make the useful constants that TimeSpan has internally declare public because they're rooted in hard reality and not changeable, and quite useful elsewhere.
Fixes dotnet#94545
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 11, 2023
@ghost
Copy link

ghost commented Nov 11, 2023

Tagging subscribers to this area: @dotnet/area-system-datetime
See info in area-owners.md if you want to be subscribed.

Issue Details

Make the useful constants that TimeSpan has internally declare public because they're rooted in hard reality and not changeable, and quite useful elsewhere.
Fixes #94545

Author: IDisposable
Assignees: -
Labels:

area-System.DateTime

Milestone: -

@danmoseley
Copy link
Member

Thanks, but the original issue needs to have the api-approved label before any PR. I suggest closing until then.

@danmoseley danmoseley closed this Nov 11, 2023
@IDisposable
Copy link
Contributor Author

That's why it's Draft :)

@IDisposable
Copy link
Contributor Author

Not sure why you would close a Draft... nor do I see how to reopen. That's not nice.

@danmoseley
Copy link
Member

@IDisposable We have many active PR's which is why we ask to get approval on new API before starting a PR.

As far as I know you can reopen it - if you can't I'm not sure why 🙂

@tannergooding
Copy link
Member

Notably, as per our CONTRIBUTING.md

Please do not:

...

  • DON'T add API additions without filing an issue and discussing with us first. See API Review Process.

Every single PR opened has a cost, even for draft PRs. This comes in the form of e-mail notifications sent to developers, cross linking to the issues, time spent by developers who are giving the PR a preliminary glance, actual cost in terms of computing hours required to run tests and other validation, which in turn has downstream environmental impact and other considerations, etc.

There is nothing in this PR that requires it to be opened before the associated proposal goes to API review and so it is functionally noise until that occurs and it can opened if it gets approved.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.DateTime community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Expose the remaining const values in TimeSpan
3 participants