Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasi] Run the mono runtime component selection logic for wasi #94738

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

lewing
Copy link
Member

@lewing lewing commented Nov 14, 2023

This filters the runtime components correctly such that we don't link both the stub and the full library.

@lewing lewing requested review from radical and removed request for marek-safar November 14, 2023 22:34
@ghost ghost assigned lewing Nov 14, 2023
@lewing lewing requested a review from maraf November 14, 2023 22:38
@lewing lewing marked this pull request as draft November 14, 2023 23:41
@lewing
Copy link
Member Author

lewing commented Nov 14, 2023

in tree needs some work

@lewing lewing marked this pull request as ready for review November 15, 2023 16:48
@lewing
Copy link
Member Author

lewing commented Nov 15, 2023

Added conditioning on the task to only use it when using the workload which is similar to what browser is doing. Should resolve the test failures.

@lewing lewing merged commit 3c082c4 into dotnet:main Nov 15, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants