Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle platform not supported during test discovery. #94844

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

vcsjones
Copy link
Member

When Browser is doing test discovery, it now more eagerly reads some static initialization that we were previously depending on conditionals preventing.

This changes the initialization to handle platform not supported in more scenarios.

Fixes #94820

When Browser is doing test discovery, it now more eagerly reads some static initialization that we were previously depending on conditionals preventing.

This changes the initialization to handle platform not supported in more scenarios.
@ghost
Copy link

ghost commented Nov 16, 2023

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

When Browser is doing test discovery, it now more eagerly reads some static initialization that we were previously depending on conditionals preventing.

This changes the initialization to handle platform not supported in more scenarios.

Fixes #94820

Author: vcsjones
Assignees: -
Labels:

area-System.Security

Milestone: -

@vcsjones
Copy link
Member Author

/azp list

This comment was marked as outdated.

@vcsjones
Copy link
Member Author

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @vcsjones !

@vcsjones vcsjones merged commit 7532f65 into dotnet:main Nov 29, 2023
161 of 165 checks passed
@vcsjones vcsjones deleted the fix-94820 branch November 29, 2023 21:45
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasm] Unhandled System.PlatformNotSupportedException for crypto tests
4 participants