Don't run crossgen2 or ilc when cross-building in source-build #95088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jkoritzinsky
approved these changes
Nov 21, 2023
jtschuster
changed the title
jtschuster
added a commit
to jtschuster/runtime
that referenced
this pull request
Nov 22, 2023
This reverts commit ef66447.
jtschuster
added a commit
that referenced
this pull request
Nov 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the runtime compatible with cross-arch compilation, we should add
--crossto the source-build build, and avoid publishing ReadyToRun or AOT compiled. The compilers don't have a valid runtime pack for the host during the crossbuild at this point, so trying to run them fails.Part of dotnet/source-build#3698