Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasi] Fix incremental, and aot/single-file builds #95307

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[wasi] Fix incremental, and aot/single-file builds #95307

merged 1 commit into from
Nov 28, 2023

Conversation

radical
Copy link
Member

@radical radical commented Nov 28, 2023 •
edited
Loading

This follows the convention from WasmApp.*targets of writing to .rsp
files, and then adding them to the dependencies to trigger native
relinking.

Fixes #95192 .
Fixes #95273 .

@radical radical added arch-wasm WebAssembly architecture area-Build-mono labels Nov 28, 2023
@ghost
Copy link

ghost commented Nov 28, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • [wasm] Move LocalBuild, and aot targets to wasm/shared
  • Runner scripts: honor $PREPEND_PATH
  • Add support for AOT projects on helix, for wasi
  • CI: Add wasi aot smoke test projects
  • misc fixes
  • Add WasiRunnerAOTTemplate.sh
  • CI: Add jobs for wasi aot/smoke tests
  • CI: Add wasi/aot jobs on runtime-wasm
  • CI: fix wasi tests list
  • Fix wasi/windows builds where WasmAssemblyFileName contains the path also
  • Remove failing tests
  • [wasm] WBT: Set RID explicitly only for library tests
  • [wasi] Fix incremental build
Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono
Milestone: -

@ghost ghost assigned radical Nov 28, 2023
@radical radical changed the title [wasm] Move LocalBuild, and aot targets to wasm/shared [wasi] Fix incremental, and aot/single-file builds Nov 28, 2023
@build-analysis build-analysis bot mentioned this pull request Nov 28, 2023
Closed
@radical
[wasi] Fix incremental build
9b68d75 
This follows the convention from `WasmApp.*targets` of writing to `.rsp`
files, and then adding them to the dependencies to trigger native
relinking.

Fixes dotnet#95192 .
Fixes dotnet#95273 .
@radical radical requested review from lewing and maraf November 28, 2023 16:59
@radical radical marked this pull request as ready for review November 28, 2023 16:59
@lewing lewing merged commit e07f80a into dotnet:main Nov 28, 2023
25 checks passed
@radical radical deleted the wasi-incremental branch November 28, 2023 19:58
@build-analysis build-analysis bot mentioned this pull request Nov 29, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@maraf maraf Awaiting requested review from maraf maraf is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar

@ilonatommy ilonatommy Awaiting requested review from ilonatommy

@pavelsavara pavelsavara Awaiting requested review from pavelsavara

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[wasi] Single file build fails with AOT [wasm] Changing DllImport does not result in a new wasm module
2 participants
@radical @lewing