Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] Added an optional HybridGlobalization run of libraries #95324

Merged
merged 28 commits into from
Dec 12, 2023
Merged

[browser] Added an optional HybridGlobalization run of libraries #95324

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
af7ee61
Interpreted, optional lane for HG.
ilonatommy Nov 28, 2023
a868a13
Move hg job to `runtime-wasm-libtests`
ilonatommy Nov 28, 2023
aafba02
Try fixing skipping HG.
ilonatommy Nov 29, 2023
25b0229
Temporarily remove, to be added in a follow up PR.
ilonatommy Nov 29, 2023
c77e13c
Added AOT version.
ilonatommy Nov 29, 2023
55feb98
Using build arg instead of helix arg.
ilonatommy Nov 29, 2023
b72d364
Start triggering WBT on wasi changes
ilonatommy Nov 29, 2023
daeeed7
Revert, wrong PR
ilonatommy Nov 29, 2023
3ae5f60
Avoid `$(HybridGlobalization) has no effect when $(InvariantGlobaliza…
ilonatommy Nov 29, 2023
3340faf
Block tests using not supported operations.
ilonatommy Dec 1, 2023
b80b5ba
Merge branch 'main' into fix-95282
ilonatommy Dec 1, 2023
82e6a0d
Hybrid Globalization cannot be treated as ICU Globalization + more Ge…
ilonatommy Dec 1, 2023
373a06b
Fact, not Theory.
ilonatommy Dec 1, 2023
cc07560
Revert: tests with remaining ICU data in hybrid should behave like ic…
ilonatommy Dec 4, 2023
b41b8bd
Block AOT lane and tests hitting PSNE
ilonatommy Dec 4, 2023
2be840d
Blocked.
ilonatommy Dec 4, 2023
330ff9f
Block failing tests + fix incorrect spaces.
ilonatommy Dec 5, 2023
661d046
Blocked non-working Node platform discovery.
ilonatommy Dec 5, 2023
6f87b7c
Revert.
ilonatommy Dec 5, 2023
03f086e
Merge branch 'main' into fix-95282
ilonatommy Dec 6, 2023
d179334
We shouldn't be using net8 machine anymore.
ilonatommy Dec 7, 2023
110ad6f
Better logging + corrected some expected results.
ilonatommy Dec 7, 2023
0d6f41e
Fix build
ilonatommy Dec 7, 2023
6202f5f
Better failure logging.
ilonatommy Dec 7, 2023
8cfb79d
Logging improvement.
ilonatommy Dec 7, 2023
466a50e
Responses to bangla and bengali are different.
ilonatommy Dec 7, 2023
93e09d6
Fix for node 17.3.1.
ilonatommy Dec 8, 2023
7cc6538
Update src/libraries/Common/tests/Tests/System/StringTests.cs
ilonatommy Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

#
# ************ Rolling builds: *************
# - only run eat, and aot tests
# - only run eat, aot and hg tests
# - rest are covered by runtime
#
- ${{ if eq(parameters.isRollingBuild, true) }}:
Expand Down Expand Up @@ -54,6 +54,21 @@ jobs:
shouldContinueOnError: true
alwaysRun: true

#ToDo: add AOT version when this is confirmed to work
#ToDo: confirm if adding it here is fine
- template: /eng/pipelines/common/templates/wasm-library-tests.yml
ilonatommy marked this conversation as resolved.
Show resolved Hide resolved
parameters:
platforms:
- browser_wasm
- browser_wasm_win
nameSuffix: _HybridGlobalization
extraHelixArgs: /p:HybridGlobalization=true
scenarios:
- normal
- WasmTestOnBrowser
- WasmTestOnNodeJS
alwaysRun: true

# Disabled for now
#- template: /eng/pipelines/coreclr/perf-wasm-jobs.yml
#parameters:
Expand Down Expand Up @@ -179,6 +194,22 @@ jobs:
scenarios:
- normal

# Hybrid Globalization tests
# ToDo: add AOT version when this is confirmed to work
- template: /eng/pipelines/common/templates/wasm-library-tests.yml
parameters:
platforms:
- browser_wasm
- browser_wasm_win
nameSuffix: _HybridGlobalization
extraHelixArgs: /p:HybridGlobalization=true
isExtraPlatformsBuild: ${{ parameters.isExtraPlatformsBuild }}
isWasmOnlyBuild: ${{ parameters.isWasmOnlyBuild }}
scenarios:
- normal
ilonatommy marked this conversation as resolved.
Show resolved Hide resolved
- WasmTestOnBrowser
- WasmTestOnNodeJS
ilonatommy marked this conversation as resolved.
Show resolved Hide resolved

- ${{ if and(ne(parameters.isRollingBuild, true), ne(parameters.excludeNonLibTests, true), ne(parameters.debuggerTestsOnly, true)) }}:
# Builds only
- template: /eng/pipelines/common/templates/wasm-build-only.yml
Expand Down Expand Up @@ -281,4 +312,4 @@ jobs:
isExtraPlatformsBuild: ${{ parameters.isExtraPlatformsBuild }}
isWasmOnlyBuild: ${{ parameters.isWasmOnlyBuild }}
scenarios:
- normal
- normal
2 changes: 2 additions & 0 deletions src/mono/wasm/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,12 +305,14 @@ npm update --lockfile-version=1

* `runtime-wasm*` pipelines are triggered manually, and they only run the jobs that would not run on any default pipelines based on path changes.
* The `AOT` jobs run only smoke tests on `runtime`, and on `runtime-wasm*` pipelines all the `AOT` tests are run.
* HG libtests are library test with `HybridGlobalization=true`

| . | runtime-wasm | runtime-wasm-libtests | runtime-wasm-non-libtests |
| ----------------- | -------------------------- | -------------------- | -------------------- |
| libtests | linux+windows: all | linux+windows: all | none |
| libtests eat | linux: all | linux: all | none |
| libtests aot | linux+windows: all | linux+windows: all | none |
| libtests hg | linux+windows: all | linux+windows: all | none |
| high resource aot | linux+windows: all | linux+windows: all | none |
| Wasm.Build.Tests | linux+windows | none | linux+windows |
| Debugger tests | linux+windows | none | linux+windows |
Expand Down
Loading