Fix iOS/tvOS NativeAOT builds #95405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet#80295 added a new entry to tryrun.cmake but iOS/tvOS use a separate tryrun_ios_tvos.cmake which was missing the new entry.
dotnet-issue-labeler
bot
added
the
needs-area-label
ghost
assigned 
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
akoeplinger
removed
the
needs-area-label
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Nov 29, 2023
While looking at dotnet#95405 I noticed that we didn't fail the build when the cmake configure step failed but tried to run the build regardless. The reason is because in ece10ad another command `popd` was added after the cmake invocation which overwrote the exit code so build-commons.sh didn't know cmake failed.
steveisok
approved these changes
Nov 29, 2023
|
Failures are unrelated. |
This was referenced Nov 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#80295 added a new entry to tryrun.cmake but iOS/tvOS use a separate tryrun_ios_tvos.cmake which was missing the new entry. Removing the separate file is tracked in #86829