JIT: Recanonicalize entry BB in JitOptRepeat scenarios #95857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I inadvertently broke the canonicalization for JitOptRepeat scenarios in my recent change where I introduced a separate phase to canonicalize the entry BB; this fixes it again.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsI inadvertently broke the canonicalization for JitOptRepeat scenarios in my recent change where I introduced a separate phase to canonicalize the entry BB; this fixes it again.
|
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS |
BruceForstall
approved these changes
Dec 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I inadvertently broke the canonicalization for JitOptRepeat scenarios in #95809 where I introduced a separate phase to canonicalize the entry BB; this fixes it again.