[wasm] rename WasmApp.* to BrowserWasmApp.* #95892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
ghost
assigned 
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
radical
requested review from
lewing,
pavelsavara,
kg and
marek-safar
as code owners
radical
requested review from
ilonatommy and
maraf
and removed request for
kg and
marek-safar
|
next step rename also |
|
And maybe also |
pavelsavara
reviewed
Dec 12, 2023
| @@ -15,8 +15,8 @@ | |||
| <PackageFile Include="$(RepoRoot)\src\mono\wasm\build\ILLink.Substitutions.*.xml" TargetPath="Sdk" /> | |||
| <PackageFile Include="$(RepoRoot)\src\mono\wasm\build\ILLink.Descriptors.*.xml" TargetPath="Sdk" /> | |||
|
|
|||
| <PackageFile Include="$(RepoRoot)\src\mono\wasm\build\WasmApp.props" TargetPath="Sdk" /> | |||
| <PackageFile Include="$(RepoRoot)\src\mono\wasm\build\WasmApp.targets" TargetPath="Sdk" /> | |||
| <PackageFile Include="$(RepoRoot)\src\mono\wasm\build\BrowserWasmApp.props" TargetPath="Sdk" /> | |||
There was a problem hiding this comment.
Naive question, are any of the msbuild files referred to by filename in the SDK ?
There was a problem hiding this comment.
Good question. A quick search didn't show anything like that. We'll have to react to it, if it breaks anything.
pavelsavara
approved these changes
Dec 12, 2023
maraf
approved these changes
Dec 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.