Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup some string operating functions #96099

Merged
merged 16 commits into from
Jan 4, 2024
Merged

Cleanup some string operating functions #96099

merged 16 commits into from
Jan 4, 2024

Commits on Dec 16, 2023

  1. IsStringLongerThan -> strnlen

    @huoyaoyuan
    huoyaoyuan committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    b733ba6 View commit details
    Browse the repository at this point in the history

  2. StringCchCopy -> u16_strcpy_s

    @huoyaoyuan
    huoyaoyuan committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    fd76ebe View commit details
    Browse the repository at this point in the history

  3. Delete strsafe.h

    @huoyaoyuan
    huoyaoyuan committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    e8d844a View commit details
    Browse the repository at this point in the history

  4. Remove FString usage in SString

    @huoyaoyuan
    huoyaoyuan committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    2794371 View commit details
    Browse the repository at this point in the history

  5. Remove fstring usage from corhlprpriv.h

    @huoyaoyuan
    huoyaoyuan committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    23947ba View commit details
    Browse the repository at this point in the history

  6. Remove fstring

    @huoyaoyuan
    huoyaoyuan committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    fa3ff62 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2023

  1. Commit suggestion from review 

    Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
    @huoyaoyuan @am11
    huoyaoyuan and am11 authored Dec 17, 2023
    Configuration menu
    Copy the full SHA
    90d51cc View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Fix compiling

    @huoyaoyuan
    huoyaoyuan committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    c756156 View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2023

  1. Fix null terminator in corhlprpriv.h

    @huoyaoyuan
    huoyaoyuan committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    7d91247 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2023

  1. Link utf8.c for Unix minipal

    @huoyaoyuan
    huoyaoyuan committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    0e11ecb View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Aaron Robinson <arobins@microsoft.com>
    @huoyaoyuan @AaronRobinsonMSFT
    huoyaoyuan and AaronRobinsonMSFT authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    128920f View commit details
    Browse the repository at this point in the history

  2. Only add link for utf8 on osx

    @huoyaoyuan
    huoyaoyuan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    765b4e3 View commit details
    Browse the repository at this point in the history

  3. Flip invariant in SString::ConvertToUTF8

    @huoyaoyuan
    huoyaoyuan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    51da9cd View commit details
    Browse the repository at this point in the history

  4. Throw ERROR_NO_UNICODE_TRANSLATION

    @huoyaoyuan
    huoyaoyuan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    1dd038d View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
    @huoyaoyuan @am11
    huoyaoyuan and am11 authored Jan 4, 2024
    Configuration menu
    Copy the full SHA
    e9137da View commit details
    Browse the repository at this point in the history

  2. Update src/coreclr/utilcode/sstring.cpp 

    Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
    @AaronRobinsonMSFT @am11
    AaronRobinsonMSFT and am11 authored Jan 4, 2024
    Configuration menu
    Copy the full SHA
    466e3d0 View commit details
    Browse the repository at this point in the history