-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] Enable trimming on Helix for Apple mobile #96169
Closed
Closed
Changes from 96 commits
Commits
Show all changes
99 commits
Select commit
Hold shift + click to select a range
8e849e4
REVERT: Disable automatic CI runs
ivanpovazan 4c33ec3
REVERT: Disable NativeAOT jobs
ivanpovazan ca292e8
Enable trimming for libraries and functional tests
ivanpovazan 60538ed
REVERT: Disable runtime tests for now
ivanpovazan 2fc0152
REVERT: Disable tvos lane
ivanpovazan cddf7cd
Disable building tests on Helix
ivanpovazan 4654eed
Try to trim on helix
d436732
Forgot the extraHelixArgs
44dd345
Merge remote-tracking branch 'upstream/main' into mono-trim-tests
b5e2ebf
Publish / link on build machine and build app on helix
6a297c2
Throw tvos back in
136e440
Get paths right for local helix test build
4315827
Merge remote-tracking branch 'upstream/main' into mono-trim-tests
629ef00
Merge remote-tracking branch 'upstream/main' into trim-ios-on-helix
bb3ae78
[infra] Add illink targets to trim app bundles on helix
kotlarmilos cfcf0e3
[infra] Fix ILLink path on Helix
kotlarmilos af197a0
[infra] Fix ILLink path on Helix
kotlarmilos 1285fb6
[infra] Fix ILLink path on Helix
kotlarmilos bcfc0e5
[infra] Fix ILLink path on Helix
kotlarmilos 6a821e1
[infra] Fix TrimmerRootAssembly item group
kotlarmilos 79a4e59
[tests] Trim library tests on devices
kotlarmilos df1bfaa
[tests] Trim library tests on devices
kotlarmilos 97f1228
[tests]
kotlarmilos da98a41
[tests] Fix failing tests
kotlarmilos c713e68
[tests] Fix failing tests
kotlarmilos 259df19
[tests] Remove redundant ILLink descriptors
kotlarmilos 8be17ac
[tests] Include ILLink descriptors
kotlarmilos f21cdbc
[tests] Copy TrimmerRootDescriptor if exist
kotlarmilos 042c25b
[tests] Remove unused item group
kotlarmilos 66a2431
Don't trim System.Linq.dll
kotlarmilos 65d048e
[tests] Disable failing test
kotlarmilos 8a7b61f
Fix typo in test platform in ConfigurationBinderTests.cs
kotlarmilos 83a6870
Add assemblies to TrimmerRootAssembly list
kotlarmilos 1aa1d51
Update IsDebuggerTypeProxyAttributeSupported condition
kotlarmilos f307ce2
[tests] Add reference paths to ILLink task
kotlarmilos 443bcbd
[tests] Remove rooted assemblies from AppleBuild.LocalBuild.targets
kotlarmilos 3444ce5
Add ILLink.Descriptors.xml files for System.Diagnostics.FileVersionIn…
kotlarmilos cf79425
Cleaning up System.Runtime.Tests
ivanpovazan 16ff8b0
Merge branch 'main' into trim-ios-on-helix
ivanpovazan 2eb9126
Do not use NativeAOT settings when building for Mono on helix
ivanpovazan ce8b1a9
Recreate the state of RuntimeConfigurationOption for trimming on helix
ivanpovazan 8ce679c
[infra] Revert RuntimeConfigurationOption and IsDebuggerTypeProxyAttr…
kotlarmilos 057d414
Merge branch 'trim-ios-on-helix' of https://github.com/kotlarmilos/ru…
kotlarmilos 42d5a6b
Disabling crashing System.Linq tests not related to trimming
ivanpovazan a679363
[tests] Disable System.Runtime.Serialization.* tests
kotlarmilos 1459ab9
Merge branch 'main' into trim-ios-on-helix
kotlarmilos ffc6d6c
[tests] Disable runtime.yml jobs
kotlarmilos 2482201
[infra] Move ioslike jobs to runtime.yml
kotlarmilos 8e3b087
[tests] Run all library tests on Apple mobile
kotlarmilos 46fc294
[tests] Disable non-compatible trim tests
kotlarmilos 0f00880
Merge branch 'main' into trim-ios-on-helix
kotlarmilos eb92999
[tests] Add nameof(PlatformDetection.IsMonoRuntime) as a condition to…
kotlarmilos ec1313c
Enable runtime.yml tests
kotlarmilos 682e42d
Merge branch 'dotnet:main' into trim-ios-on-helix
kotlarmilos 28243cc
Disable runtime.yml jobs
kotlarmilos 0907644
[infra] Pass additional feature switches to test trimming
kotlarmilos bd31109
[infra] Pass additional feature switches to test trimming
kotlarmilos af8bfac
[infra] Fix conditional fact attribute
kotlarmilos 166af0d
Enable runtime.yml jobs
kotlarmilos 1434a46
Merge branch 'dotnet:main' into trim-ios-on-helix
kotlarmilos 835bffe
Disable runtime.yml jobs
kotlarmilos 4d3e329
Fix System.IO.FileSystem.Tests
ivanpovazan 3df484e
Including full path for TrimmerRootAssemblies breaks when building on…
ivanpovazan e486f8c
[tests] Disable failing tests
kotlarmilos bd73730
Add TrimmerRootDescriptor to System.Configuration.ConfigurationManage…
kotlarmilos b2f77b5
Add System.Configuration.AppSettingsSection to ILLink.Descriptors.xml
kotlarmilos c06337d
Update ILLink descriptors with System.Configuration types
kotlarmilos 08632d4
Add new types to ILLink.Descriptors.xml
kotlarmilos e78e3a4
Add new types to ILLink.Descriptors.xml
kotlarmilos 21c4423
Add missing types to ILLink.Descriptors.xml
kotlarmilos 66ebc16
Enable runtime.yml jobs
kotlarmilos d808a90
Merge branch 'main' into trim-ios-on-helix
kotlarmilos 39b2794
Disable runtime.yml jobs
kotlarmilos 50140e6
Remove duplicates in ILLink.Descriptors.xml
kotlarmilos 09b8a92
Fix trimming-related failures
kotlarmilos eb688cf
Fix trimming-related failures
kotlarmilos ee90b19
Add TrimmerRootAssembly for System.Text.Json.Tests
kotlarmilos dc45f28
Update TrimmerRootAssembly for System.Text.Json.Tests
kotlarmilos 0ac15ec
Fix trimming-related failures
kotlarmilos 7a3f771
Enable reflection and preserve required assemblies in System.Text.Jso…
kotlarmilos cf1adc6
Revert temporary changes
kotlarmilos 81c5563
Update JsonSerializerIsReflectionEnabledByDefault condition
kotlarmilos 6c17bce
Fix ioslike extra platforms config
kotlarmilos 88fadfb
Add ILLink.Descriptors.xml files for linker configuration
kotlarmilos f374de8
Remove ActiveIssue attribute for resolved issues
kotlarmilos 9dade72
Disable ShimsHaveOnlyTypeForwards test as forwarded types are not tri…
kotlarmilos ab8b60f
Remove unknown libraries from ILLink.Descriptors.xml
kotlarmilos a60e037
Remove unknown types from ILLink.Descriptors.xml
kotlarmilos c8d5633
Fix trimming issues on non-Apple mobile platforms
kotlarmilos ce10bb2
Fix trimming failures
kotlarmilos 3441932
Add assemblies to ILLink.Descriptors.xml
kotlarmilos 4e942dd
Disable failing tests
kotlarmilos c6caaa5
Merge branch 'main' into trim-ios-on-helix
kotlarmilos fda7a6b
Add iOS-specific illink descriptor
kotlarmilos 94ba5f4
Merge branch 'dotnet:main' into trim-ios-on-helix
kotlarmilos f2cc82e
Revert postBuildSteps changes
kotlarmilos ff3b586
Merge branch 'main' into trim-ios-on-helix
kotlarmilos 7758009
Refactor proxy project to remove redundant props and items
kotlarmilos d1377de
Exclude _RemovedManagedAssembly from AppleAssembliesToBundle
kotlarmilos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
src/libraries/System.Configuration.ConfigurationManager/tests/ILLink.Descriptors.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
<linker> | ||
<assembly fullname="System" /> | ||
<assembly fullname="System.Private.CoreLib" /> | ||
<assembly fullname="System.Configuration" /> | ||
<assembly fullname="System.Configuration.ConfigurationManager" /> | ||
</linker> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
src/libraries/System.Data.Common/tests/ILLink.Descriptors.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
<linker> | ||
<assembly fullname="System.Data" /> | ||
</linker> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
...ics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/ILLink.Descriptors.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
<linker> | ||
<assembly fullname="System.Diagnostics.FileVersionInfo.TestAssembly" /> | ||
</linker> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<linker> | ||
<assembly fullname="System.Linq" /> | ||
<assembly fullname="System.Linq.Tests" /> | ||
<assembly fullname="System.Runtime" /> | ||
</linker> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
src/libraries/System.Reflection.TypeExtensions/tests/ILLink.Descriptors.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
<linker> | ||
<assembly fullname="TinyAssembly" /> | ||
</linker> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
src/libraries/System.Resources.Extensions/tests/ILLink.Descriptors.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
<linker> | ||
<assembly fullname="System.Drawing" /> | ||
<assembly fullname="System.Resources.Extensions" /> | ||
</linker> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which scenarios would we not want to use the portable runtime pack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can revert this change. We were testing different options for trimming on helix and one of them was to trim on build machines.